FEAT #16982 TIME 0:30 save correct role for otp yousign + error in getbyDocumentId workflow route

src/app/user/controllers/SignatureController.php

@@ -249,6 +249,9 @@ class SignatureController
         }
 
         $validModes = CoreConfigModel::getSignatureModes();
+        array_push($validModes, ['id' => 'otp_visa_yousign']);
+        array_push($validModes, ['id' => 'otp_sign_yousign']);
+
         foreach ($validModes as $validMode) {
             if ($validMode['id'] == $args['mode']) {
                 return true;

src/app/workflow/controllers/WorkflowController.php

@@ -24,6 +24,7 @@ use Respect\Validation\Validator;
 use Slim\Http\Request;
 use Slim\Http\Response;
 use User\models\UserModel;
+use Workflow\models\WorkflowExternalInformationModel;
 use Workflow\models\WorkflowModel;
 
 class WorkflowController
@@ -43,9 +44,18 @@ class WorkflowController
                 $value['process_date'] = $date->format('d-m-Y H:i');
             }
 
+            if (in_array($value['signature_mode'], ['otp_visa_yousign', 'otp_sign_yousign'])) {
+                $workflowExternalInformations = WorkflowExternalInformationModel::getByWorkflowId(['select' => ['firstname', 'lastname'], 'workflowId' => $value['id']]);
+                if (!empty($workflowExternalInformations)) {
+                    $userDisplay = "{$workflowExternalInformations['firstname']} {$workflowExternalInformations['lastname']}";
+                }
+            } else {
+                $userDisplay = UserModel::getLabelledUserById(['id' => $value['user_id']]);
+            }
+            
             $workflow[] = [
                 'userId'        => $value['user_id'],
-                'userDisplay'   => UserModel::getLabelledUserById(['id' => $value['user_id']]),
+                'userDisplay'   => $userDisplay,
                 'mode'          => $value['mode'],
                 'signatureMode' => $value['signature_mode'],
                 'order'         => $value['order'],