FIX #5327 remove getusersavis() from "for" loop

modules/avis/class/avis_controler_Abstract.php

@@ -62,10 +62,10 @@ abstract class avis_controler_Abstract
             $str .= '<option value="" ></option>';
 
             $tab_userentities = $this->getEntityAvis();
+            $tab_users = $this->getUsersAvis();
             //Order by parent entity
             foreach ($tab_userentities as $key => $value) {
                 $str .= '<optgroup label="' . $tab_userentities[$key]['entity_id'] . '">';
-                $tab_users = $this->getUsersAvis($tab_usergroups[$key]['group_id']);
                 foreach ($tab_users as $user) {
                     if ($tab_userentities[$key]['entity_id'] == $user['entity_id']) {
                         $selected = " ";

modules/avis/load_listmodel_avis.php

@@ -86,11 +86,11 @@ require_once "modules" . DIRECTORY_SEPARATOR . "avis" . DIRECTORY_SEPARATOR
 			$content .= '<option value="" >Sélectionnez un utilisateur</option>';
 			
 			$tab_userentities = $avis->getEntityAvis();
+			$tab_users = $avis->getUsersAvis();
 
 			/** Order by parent entity **/
 			foreach ($tab_userentities as $key => $value) {
 				$content .= '<optgroup label="'.$tab_userentities[$key]['entity_id'].'">';
-				$tab_users = $avis->getUsersAvis($tab_usergroups[$key]['group_id']);
 				foreach($tab_users as $user){
 					if($tab_userentities[$key]['entity_id'] == $user['entity_id']){
 						$selected = " ";

modules/avis/load_listmodel_avis_popup.php

@@ -81,17 +81,16 @@ require_once "modules" . DIRECTORY_SEPARATOR . "avis" . DIRECTORY_SEPARATOR
 			$content .= '<tr ' . $color . '>';
 			$content .= '<td>';
 
-			$tab_users = $avis->getUsersAvis();
 			$content .= '<span id="avisPopup_rank_' . $seq . '"> <span class="nbResZero" style="font-weight:bold;opacity:0.5;">'. ($seq + 1) .'</span> </span>';
 			$content .= '<select id="avisPopup_'.$seq.'" name="avisPopup_'.$seq.'" >';
 			$content .= '<option value="" >Sélectionnez un utilisateur</option>';
 			
 			$tab_userentities = $avis->getEntityAvis();
+			$tab_users = $avis->getUsersAvis();
 
 			/** Order by parent entity **/
 			foreach ($tab_userentities as $key => $value) {
 				$content .= '<optgroup label="'.$tab_userentities[$key]['entity_id'].'">';
-				$tab_users = $avis->getUsersAvis($tab_usergroups[$key]['group_id']);
 				foreach($tab_users as $user){
 					if($tab_userentities[$key]['entity_id'] == $user['entity_id']){
 						$selected = " ";