FEAT #15527 TIME 0:15 removed useless field IndexingModelField::editable

src/app/indexingModel/controllers/IndexingModelController.php

@@ -73,7 +73,7 @@ class IndexingModelController
             return $response->withStatus(400)->withJson(['errors' => 'Model out of perimeter']);
         }
 
-        $fields = IndexingModelFieldModel::get(['select' => ['identifier', 'mandatory', 'default_value', 'unit', 'enabled', 'editable', 'allowed_values'], 'where' => ['model_id = ?'], 'data' => [$args['id']]]);
+        $fields = IndexingModelFieldModel::get(['select' => ['identifier', 'mandatory', 'default_value', 'unit', 'enabled', 'allowed_values'], 'where' => ['model_id = ?'], 'data' => [$args['id']]]);
         $destination = '';
         foreach ($fields as $key => $value) {
             $fields[$key]['default_value'] = json_decode($value['default_value'], true);
@@ -252,7 +252,6 @@ class IndexingModelController
                 'enabled'        => $field['enabled'] === false ? 'false' : 'true',
                 'default_value'  => !isset($field['default_value']) ? null : json_encode($field['default_value']),
                 'unit'           => $field['unit'],
-                'editable'       => $field['editable'] === true ? 'true' : 'false',
                 'allowed_values' => !isset($field['allowedValues']) ? null : json_encode($field['allowedValues']),
             ]);
         }
@@ -390,7 +389,6 @@ class IndexingModelController
                         'enabled'        => $field['enabled'] === false ? 'false' : 'true',
                         'default_value'  => !isset($field['default_value']) ? null : json_encode($field['default_value']),
                         'unit'           => $field['unit'],
-                        'editable'       => $field['editable'] === false ? 'false' : 'true',
                         'allowed_values' => !isset($field['allowedValues']) ? null : json_encode($field['allowedValues']),
                     ]);
                 }
@@ -459,7 +457,6 @@ class IndexingModelController
                 'enabled'        => $field['enabled'] === false ? 'false' : 'true',
                 'default_value'  => !isset($field['default_value']) ? null : json_encode($field['default_value']),
                 'unit'           => $field['unit'],
-                'editable'       => $field['editable'] === false ? 'false' : 'true',
                 'allowed_values' => !isset($field['allowedValues']) ? null : json_encode($field['allowedValues']),
             ]);
         }

src/app/indexingModel/models/IndexingModelFieldModel.php

@@ -38,8 +38,8 @@ class IndexingModelFieldModel
 
     public static function create(array $args)
     {
-        ValidatorModel::notEmpty($args, ['model_id', 'enabled', 'mandatory', 'identifier', 'unit', 'editable']);
-        ValidatorModel::stringType($args, ['enabled', 'mandatory', 'identifier', 'unit', 'editable']);
+        ValidatorModel::notEmpty($args, ['model_id', 'enabled', 'mandatory', 'identifier', 'unit']);
+        ValidatorModel::stringType($args, ['enabled', 'mandatory', 'identifier', 'unit']);
         ValidatorModel::intVal($args, ['model_id']);
 
         DatabaseModel::insert([
@@ -51,7 +51,6 @@ class IndexingModelFieldModel
                 'enabled'        => $args['enabled'],
                 'default_value'  => $args['default_value'],
                 'unit'           => $args['unit'],
-                'editable'       => $args['editable'],
                 'allowed_values' => $args['allowed_values'],
             ]
         ]);

src/app/resource/controllers/ResourceControlController.php

@@ -374,7 +374,7 @@ class ResourceControlController
     {
         $body = $args['body'];
 
-        $indexingModelFields = IndexingModelFieldModel::get(['select' => ['identifier', 'mandatory', 'editable', 'default_value', 'allowed_values'], 'where' => ['model_id = ?'], 'data' => [$body['modelId']]]);
+        $indexingModelFields = IndexingModelFieldModel::get(['select' => ['identifier', 'mandatory', 'default_value', 'allowed_values'], 'where' => ['model_id = ?'], 'data' => [$body['modelId']]]);
         foreach ($indexingModelFields as $indexingModelField) {
             $indexingModelField['default_value'] = json_decode($indexingModelField['default_value'], true);
             $indexingModelField['allowed_values'] = json_decode($indexingModelField['allowed_values'], true);
@@ -420,8 +420,6 @@ class ResourceControlController
                         return ['errors' => "Body customFields[{$customFieldId}] is not a number"];
                     } elseif ($customField['type'] == 'date' && !Validator::date()->notEmpty()->validate($body['customFields'][$customFieldId])) {
                         return ['errors' => "Body customFields[{$customFieldId}] is not a date"];
-                    } elseif (!$indexingModelField['editable'] && $body['customFields'][$customFieldId] != $indexingModelField['default_value']) {
-                        return ['errors' => "Body {$indexingModelField['identifier']} is not editable and differs from default value ({$indexingModelField['default_value']})"];
                     } elseif (!empty($indexingModelField['allowed_values']) && !in_array($body['customFields'][$customFieldId], $indexingModelField['allowed_values'])) {
                         return ['errors' => "Body {$indexingModelField['identifier']} is not one of the allowed values"];
                     }
@@ -430,8 +428,6 @@ class ResourceControlController
                 continue;
             } elseif ($indexingModelField['mandatory'] && !isset($body[$indexingModelField['identifier']])) {
                 return ['errors' => "Body {$indexingModelField['identifier']} is not set"];
-            } elseif (!$indexingModelField['editable'] && $body[$indexingModelField['identifier']] != $indexingModelField['default_value']) {
-                return ['errors' => "Body {$indexingModelField['identifier']} is not editable and defers from default value ({$indexingModelField['default_value']})"];
             } elseif (!empty($indexingModelField['allowed_values']) && !in_array($body[$indexingModelField['identifier']], $indexingModelField['allowed_values'])) {
                 return ['errors' => "Body {$indexingModelField['identifier']} is not one of the allowed values"];
             }

src/frontend/app/indexation/indexing-form/indexing-form.component.ts

@@ -997,7 +997,7 @@ export class IndexingFormComponent implements OnInit {
     }
 
     isAlwaysDisabledField(field: any) {
-        if ((this.adminMode && ((['integer', 'string', 'date'].indexOf(field.type) > -1 && !this.functions.empty(field.values)) || field.today)) || !field.editable) {
+        if (this.adminMode && ((['integer', 'string', 'date'].indexOf(field.type) > -1 && !this.functions.empty(field.values)) || field.today)) {
             return true;
         }
         return false;