From ffdcda8571d0340fad0e3c8ad1195f58706ac497 Mon Sep 17 00:00:00 2001
From: lebozec <nicolas.lebozec@xelians.fr>
Date: Tue, 28 Feb 2023 16:10:14 +0100
Subject: [PATCH] FIX #22934 TIME 0:20 Add check if getUserInformationsById is
empty
---
src/app/user/controllers/UserController.php | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/app/user/controllers/UserController.php b/src/app/user/controllers/UserController.php
index 142157718f..ae060a9498 100755
--- a/src/app/user/controllers/UserController.php
+++ b/src/app/user/controllers/UserController.php
@@ -106,8 +106,12 @@ class UserController
return $response->withStatus(400)->withJson(['errors' => 'Route id is not an integer']);
}
+
if ($GLOBALS['id'] == $args['id'] || PrivilegeController::hasPrivilege(['userId' => $GLOBALS['id'], 'privilege' => 'manage_users'])) {
$user = UserController::getUserInformationsById(['id' => $args['id']]);
+ if (empty($user)) {
+ return $response->withStatus(400)->withJson(['errors' => 'User does not exist']);
+ }
$user['groups'] = [];
$userGroups = UserGroupModel::get(['select' => ['group_id'], 'where' => ['user_id = ?'], 'data' => [$args['id']]]);
$groupsIds = array_column($userGroups, 'group_id');
@@ -119,7 +123,6 @@ class UserController
} else {
$user = UserModel::getById(['select' => ['id', 'firstname', 'lastname', 'email', 'phone', 'substitute'], 'id' => $args['id']]);
}
-
if (empty($user)) {
return $response->withStatus(400)->withJson(['errors' => 'User does not exist']);
}
--
GitLab