From abb4037bb94c9c1ddb02973a94b80d4c1e08bd0a Mon Sep 17 00:00:00 2001 From: Damien Burel <damien.burel@maarch.org> Date: Mon, 31 Jul 2017 10:55:26 +0200 Subject: [PATCH] FIX #5790 Fix nosignable attchments when empty --- modules/visa/class/class_modules_tools_Abstract.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/modules/visa/class/class_modules_tools_Abstract.php b/modules/visa/class/class_modules_tools_Abstract.php index ff4cc9c48e2..99f40737042 100644 --- a/modules/visa/class/class_modules_tools_Abstract.php +++ b/modules/visa/class/class_modules_tools_Abstract.php @@ -236,7 +236,11 @@ abstract class visa_Abstract extends Database } $db = new Database(); - $stmt = $db->query("SELECT * FROM res_view_attachments WHERE res_id_master = ? AND coll_id = ? AND status NOT IN ('DEL','OBS','TMP') AND attachment_type NOT IN (?) ", [$res_id, $coll_id, $noSignableAttachments]); + if (empty($noSignableAttachments)) { + $stmt = $db->query("SELECT * FROM res_view_attachments WHERE res_id_master = ? AND coll_id = ? AND status NOT IN ('DEL','OBS','TMP')", [$res_id, $coll_id]); + } else { + $stmt = $db->query("SELECT * FROM res_view_attachments WHERE res_id_master = ? AND coll_id = ? AND status NOT IN ('DEL','OBS','TMP') AND attachment_type NOT IN (?) ", [$res_id, $coll_id, $noSignableAttachments]); + } if ($stmt->rowCount() <= 0) { $this->errorMessageVisa = _NO_RESPONSE_PROJECT_VISA; return false; -- GitLab