From 7691686a15fc38b61de2d0780985510ad9a138d3 Mon Sep 17 00:00:00 2001
From: Guillaume Heurtier <guillaume.heurtier@maarch.org>
Date: Thu, 2 Apr 2020 11:22:15 +0200
Subject: [PATCH] FEAT #13676 TIME 1:20 improved shipping unit tests
---
.../app/shipping/ShippingControllerTest.php | 260 +++++++++++++++++-
1 file changed, 254 insertions(+), 6 deletions(-)
diff --git a/test/unitTests/app/shipping/ShippingControllerTest.php b/test/unitTests/app/shipping/ShippingControllerTest.php
index 6bb48ed03ce..fd4daec9a4b 100755
--- a/test/unitTests/app/shipping/ShippingControllerTest.php
+++ b/test/unitTests/app/shipping/ShippingControllerTest.php
@@ -12,6 +12,7 @@ use PHPUnit\Framework\TestCase;
class ShippingTemplateControllerTest extends TestCase
{
private static $id = null;
+ private static $resId = null;
public function testCreate()
{
@@ -33,6 +34,7 @@ class ShippingTemplateControllerTest extends TestCase
$fullRequest = \httpRequestCustom::addContentInBody($aArgs, $request);
$response = $shipping->create($fullRequest, new \Slim\Http\Response());
+ $this->assertSame(200, $response->getStatusCode());
$responseBody = json_decode((string)$response->getBody());
$this->assertIsInt($responseBody->shippingId);
@@ -40,21 +42,59 @@ class ShippingTemplateControllerTest extends TestCase
####### FAIL ##########
$aArgs = [
- 'description' => 'description du TEST',
- 'options' => [
- 'shaping' => ['color', 'duplexPrinting', 'addressPage'],
- 'sendMode' => 'fast'
+ 'description' => 'description too long !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!',
+ 'options' => [
+ 'shaping' => ['color', 'duplexPrinting', 'addressPage'],
+ 'sendMode' => 'fast'
],
- 'fee' => ['firstPagePrice' => 1, 'nextPagePrice' => 2, 'postagePrice' => 12],
- 'account' => ['id' => 'toto', 'password' => '']
+ 'fee' => ['firstPagePrice' => 1, 'nextPagePrice' => 2, 'postagePrice' => -12],
+ 'account' => ['id' => 'toto', 'password' => ''],
+ 'entities' => [99999]
+ ];
+ $fullRequest = \httpRequestCustom::addContentInBody($aArgs, $request);
+
+ $response = $shipping->create($fullRequest, new \Slim\Http\Response());
+ $this->assertSame(400, $response->getStatusCode());
+ $responseBody = json_decode((string)$response->getBody());
+
+ $this->assertSame('account id or password is empty', $responseBody->errors[0]);
+ $this->assertSame('label is empty or too long', $responseBody->errors[1]);
+ $this->assertSame('description is empty or too long', $responseBody->errors[2]);
+ $this->assertSame('99999 does not exists', $responseBody->errors[3]);
+ $this->assertSame('fee must be an array with positive values', $responseBody->errors[4]);
+
+ $aArgs = [
+ 'description' => 'description',
+ 'options' => [
+ 'shaping' => ['color', 'duplexPrinting', 'addressPage'],
+ 'sendMode' => 'fast'
+ ],
+ 'fee' => ['firstPagePrice' => 1, 'nextPagePrice' => 2, 'postagePrice' => 12],
+ 'account' => ['id' => 'toto', 'password' => ''],
+ 'entities' => 'wrong format'
];
$fullRequest = \httpRequestCustom::addContentInBody($aArgs, $request);
$response = $shipping->create($fullRequest, new \Slim\Http\Response());
+ $this->assertSame(400, $response->getStatusCode());
$responseBody = json_decode((string)$response->getBody());
$this->assertSame('account id or password is empty', $responseBody->errors[0]);
$this->assertSame('label is empty or too long', $responseBody->errors[1]);
+ $this->assertSame('entities must be an array', $responseBody->errors[2]);
+
+ $GLOBALS['userId'] = 'bbain';
+ $userInfo = \User\models\UserModel::getByLogin(['login' => $GLOBALS['userId'], 'select' => ['id']]);
+ $GLOBALS['id'] = $userInfo['id'];
+
+ $response = $shipping->create($request, new \Slim\Http\Response());
+ $this->assertSame(403, $response->getStatusCode());
+ $responseBody = json_decode((string)$response->getBody());
+ $this->assertSame('Service forbidden', $responseBody->errors);
+
+ $GLOBALS['userId'] = 'superadmin';
+ $userInfo = \User\models\UserModel::getByLogin(['login' => $GLOBALS['userId'], 'select' => ['id']]);
+ $GLOBALS['id'] = $userInfo['id'];
}
public function testGetById()
@@ -64,6 +104,7 @@ class ShippingTemplateControllerTest extends TestCase
$shipping = new \Shipping\controllers\ShippingTemplateController();
$response = $shipping->getById($request, new \Slim\Http\Response(), ['id' => self::$id]);
+ $this->assertSame(200, $response->getStatusCode());
$responseBody = json_decode((string)$response->getBody());
$this->assertNotEmpty($responseBody);
@@ -81,8 +122,27 @@ class ShippingTemplateControllerTest extends TestCase
######## ERROR #############
$response = $shipping->getById($request, new \Slim\Http\Response(), ['id' => 999999999]);
+ $this->assertSame(400, $response->getStatusCode());
$responseBody = json_decode((string)$response->getBody());
$this->assertSame('Shipping does not exist', $responseBody->errors);
+
+ $response = $shipping->getById($request, new \Slim\Http\Response(), ['id' => 'wrong format']);
+ $this->assertSame(400, $response->getStatusCode());
+ $responseBody = json_decode((string)$response->getBody());
+ $this->assertSame('id is not an integer', $responseBody->errors);
+
+ $GLOBALS['userId'] = 'bbain';
+ $userInfo = \User\models\UserModel::getByLogin(['login' => $GLOBALS['userId'], 'select' => ['id']]);
+ $GLOBALS['id'] = $userInfo['id'];
+
+ $response = $shipping->getById($request, new \Slim\Http\Response(), ['id' => self::$id]);
+ $this->assertSame(403, $response->getStatusCode());
+ $responseBody = json_decode((string)$response->getBody());
+ $this->assertSame('Service forbidden', $responseBody->errors);
+
+ $GLOBALS['userId'] = 'superadmin';
+ $userInfo = \User\models\UserModel::getByLogin(['login' => $GLOBALS['userId'], 'select' => ['id']]);
+ $GLOBALS['id'] = $userInfo['id'];
}
public function testGetList()
@@ -99,6 +159,20 @@ class ShippingTemplateControllerTest extends TestCase
foreach ($responseBody->shippings as $value) {
$this->assertIsInt($value->id);
}
+
+ // Fail
+ $GLOBALS['userId'] = 'bbain';
+ $userInfo = \User\models\UserModel::getByLogin(['login' => $GLOBALS['userId'], 'select' => ['id']]);
+ $GLOBALS['id'] = $userInfo['id'];
+
+ $response = $shipping->get($request, new \Slim\Http\Response());
+ $this->assertSame(403, $response->getStatusCode());
+ $responseBody = json_decode((string)$response->getBody());
+ $this->assertSame('Service forbidden', $responseBody->errors);
+
+ $GLOBALS['userId'] = 'superadmin';
+ $userInfo = \User\models\UserModel::getByLogin(['login' => $GLOBALS['userId'], 'select' => ['id']]);
+ $GLOBALS['id'] = $userInfo['id'];
}
public function testUpdate()
@@ -143,6 +217,63 @@ class ShippingTemplateControllerTest extends TestCase
$this->assertSame(20, $responseBody->shipping->fee->nextPagePrice);
$this->assertSame(12, $responseBody->shipping->fee->postagePrice);
$this->assertNotNull($responseBody->entities);
+
+ $environment = \Slim\Http\Environment::mock(['REQUEST_METHOD' => 'PUT']);
+ $request = \Slim\Http\Request::createFromEnvironment($environment);
+
+ $aArgs = [
+ 'description' => 'description',
+ 'options' => [
+ 'shaping' => ['color', 'duplexPrinting', 'addressPage'],
+ 'sendMode' => 'fast'
+ ],
+ 'fee' => ['firstPagePrice' => 1, 'nextPagePrice' => 2, 'postagePrice' => 12],
+ 'account' => ['id' => 'toto', 'password' => '1234'],
+ 'entities' => 'wrong format'
+ ];
+ $fullRequest = \httpRequestCustom::addContentInBody($aArgs, $request);
+
+ $response = $shipping->update($fullRequest, new \Slim\Http\Response(), ['id' => 'wrong format']);
+ $this->assertSame(500, $response->getStatusCode());
+ $responseBody = json_decode((string)$response->getBody());
+
+ $this->assertSame('Id is not a numeric', $responseBody->errors[0]);
+ $this->assertSame('Shipping does not exist', $responseBody->errors[1]);
+ $this->assertSame('label is empty or too long', $responseBody->errors[2]);
+ $this->assertSame('entities must be an array', $responseBody->errors[3]);
+
+ $aArgs = [
+ 'label' => 'TEST 2',
+ 'description' => 'description du test 2',
+ 'options' => [
+ 'shaping' => ['color', 'address_page'],
+ 'sendMode' => 'fast'
+ ],
+ 'fee' => ['firstPagePrice' => 10, 'nextPagePrice' => 20, 'postagePrice' => 12],
+ 'account' => ['id' => 'toto']
+ ];
+
+ $fullRequest = \httpRequestCustom::addContentInBody($aArgs, $request);
+
+ $shipping = new \Shipping\controllers\ShippingTemplateController();
+ $response = $shipping->update($fullRequest, new \Slim\Http\Response(), ['id' => self::$id]);
+
+ $responseBody = json_decode((string)$response->getBody());
+
+ $this->assertSame('success', $responseBody->success);
+
+ $GLOBALS['userId'] = 'bbain';
+ $userInfo = \User\models\UserModel::getByLogin(['login' => $GLOBALS['userId'], 'select' => ['id']]);
+ $GLOBALS['id'] = $userInfo['id'];
+
+ $response = $shipping->update($request, new \Slim\Http\Response(), ['id' => self::$id]);
+ $this->assertSame(403, $response->getStatusCode());
+ $responseBody = json_decode((string)$response->getBody());
+ $this->assertSame('Service forbidden', $responseBody->errors);
+
+ $GLOBALS['userId'] = 'superadmin';
+ $userInfo = \User\models\UserModel::getByLogin(['login' => $GLOBALS['userId'], 'select' => ['id']]);
+ $GLOBALS['id'] = $userInfo['id'];
}
public function testDelete()
@@ -160,6 +291,23 @@ class ShippingTemplateControllerTest extends TestCase
$response = $shipping->delete($request, new \Slim\Http\Response(), ['id' => 'myid']);
$responseBody = json_decode((string)$response->getBody());
$this->assertSame('id is not an integer', $responseBody->errors);
+
+ $response = $shipping->delete($request, new \Slim\Http\Response(), ['id' => self::$id * 1000]);
+ $responseBody = json_decode((string)$response->getBody());
+ $this->assertSame('Shipping does not exist', $responseBody->errors);
+
+ $GLOBALS['userId'] = 'bbain';
+ $userInfo = \User\models\UserModel::getByLogin(['login' => $GLOBALS['userId'], 'select' => ['id']]);
+ $GLOBALS['id'] = $userInfo['id'];
+
+ $response = $shipping->delete($request, new \Slim\Http\Response(), ['id' => self::$id]);
+ $this->assertSame(403, $response->getStatusCode());
+ $responseBody = json_decode((string)$response->getBody());
+ $this->assertSame('Service forbidden', $responseBody->errors);
+
+ $GLOBALS['userId'] = 'superadmin';
+ $userInfo = \User\models\UserModel::getByLogin(['login' => $GLOBALS['userId'], 'select' => ['id']]);
+ $GLOBALS['id'] = $userInfo['id'];
}
public function testInitShipping()
@@ -177,5 +325,105 @@ class ShippingTemplateControllerTest extends TestCase
$this->assertNotNull($value->entity_id);
$this->assertNotNull($value->entity_label);
}
+
+ // Fail
+ $GLOBALS['userId'] = 'bbain';
+ $userInfo = \User\models\UserModel::getByLogin(['login' => $GLOBALS['userId'], 'select' => ['id']]);
+ $GLOBALS['id'] = $userInfo['id'];
+
+ $response = $shipping->initShipping($request, new \Slim\Http\Response());
+ $this->assertSame(403, $response->getStatusCode());
+ $responseBody = json_decode((string)$response->getBody());
+ $this->assertSame('Service forbidden', $responseBody->errors);
+
+ $GLOBALS['userId'] = 'superadmin';
+ $userInfo = \User\models\UserModel::getByLogin(['login' => $GLOBALS['userId'], 'select' => ['id']]);
+ $GLOBALS['id'] = $userInfo['id'];
+ }
+
+ public function testGetByResId()
+ {
+ $GLOBALS['userId'] = 'cchaplin';
+ $userInfo = \User\models\UserModel::getByLogin(['login' => $GLOBALS['userId'], 'select' => ['id']]);
+ $GLOBALS['id'] = $userInfo['id'];
+
+ $resController = new \Resource\controllers\ResController();
+
+ // CREATE
+ $environment = \Slim\Http\Environment::mock(['REQUEST_METHOD' => 'POST']);
+ $request = \Slim\Http\Request::createFromEnvironment($environment);
+
+ $fileContent = file_get_contents('test/unitTests/samples/test.txt');
+ $encodedFile = base64_encode($fileContent);
+
+ $argsMailNew = [
+ 'modelId' => 1,
+ 'status' => 'NEW',
+ 'encodedFile' => $encodedFile,
+ 'format' => 'txt',
+ 'confidentiality' => false,
+ 'documentDate' => '2019-01-01 17:18:47',
+ 'arrivalDate' => '2019-01-01 17:18:47',
+ 'processLimitDate' => '2029-01-01',
+ 'doctype' => 102,
+ 'destination' => 15,
+ 'initiator' => 15,
+ 'subject' => 'Breaking News : Superman is alive - PHP unit',
+ 'typist' => 19,
+ 'priority' => 'poiuytre1357nbvc',
+ 'followed' => true,
+ 'diffusionList' => [
+ [
+ 'id' => 11,
+ 'type' => 'user',
+ 'mode' => 'dest'
+ ]
+ ]
+ ];
+ $fullRequest = \httpRequestCustom::addContentInBody($argsMailNew, $request);
+
+ $response = $resController->create($fullRequest, new \Slim\Http\Response());
+ $responseBody = json_decode((string)$response->getBody(), true);
+ self::$resId = $responseBody['resId'];
+ $this->assertIsInt(self::$resId);
+
+ \Shipping\models\ShippingModel::create([
+ 'userId' => $GLOBALS['id'],
+ 'documentId' => self::$resId,
+ 'documentType' => 'resource',
+ 'options' => json_encode(
+ [
+ 'shaping' => ['color', 'duplexPrinting', 'addressPage'],
+ 'sendMode' => 'fast'
+ ]),
+ 'fee' => 2,
+ 'recipientEntityId' => 13,
+ 'accountId' => 'toto',
+ 'recipients' => json_encode(['Recipient', 'contact'])
+ ]);
+
+ $environment = \Slim\Http\Environment::mock(['REQUEST_METHOD' => 'GET']);
+ $request = \Slim\Http\Request::createFromEnvironment($environment);
+
+ // Fail
+ $response = \Shipping\controllers\ShippingController::getByResId($request, new \Slim\Http\Response(), ['resId' => self::$resId * 1000]);
+ $this->assertSame(403, $response->getStatusCode());
+ $responseBody = json_decode((string)$response->getBody(), true);
+ $this->assertSame('Document out of perimeter', $responseBody['errors']);
+
+ // Success
+ $response = \Shipping\controllers\ShippingController::getByResId($request, new \Slim\Http\Response(), ['resId' => self::$resId]);
+ $this->assertSame(200, $response->getStatusCode());
+ $responseBody = json_decode((string)$response->getBody(), true);
+
+ $this->assertSame(self::$resId, $responseBody[0]['documentId']);
+ $this->assertSame('resource', $responseBody[0]['documentType']);
+ $this->assertSame($GLOBALS['id'], $responseBody[0]['userId']);
+ $this->assertSame('2', $responseBody[0]['fee']);
+ $this->assertSame(13, $responseBody[0]['recipientEntityId']);
+
+ $GLOBALS['userId'] = 'superadmin';
+ $userInfo = \User\models\UserModel::getByLogin(['login' => $GLOBALS['userId'], 'select' => ['id']]);
+ $GLOBALS['id'] = $userInfo['id'];
}
}
--
GitLab